-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New accounts #1193
New accounts #1193
Conversation
I'm converting this to a draft while it is work-in-progress. |
@gorkemarslan What should I change, I am a bit confused actually!😅 |
@AbhijithGanesh, why did you revert your initial changes? 😅 @brylie wants you to create new views. I guess this is one of the missing parts. Edit: I didn't completely review your first changes but they seem ok with me. At which point do you need clarification? Are you confused by the template part? Apparently, you did well it. Again, I didn't try to run your changes. Of course, we are going to think of views part together and find a way to solve that. |
My doubt is, are we going to make new views for |
New views are optional. The wording in the issue is "as needed," meaning we may not need them. The goal is to have a fully functional accounts app with only Django templates and views to remove the Backbone code. Implementation details are at your discretion. |
This PR has a fully functional accounts app right? I've removed the backbone code too I guess. If I haven't please request a review, I will make changes. |
@AbhijithGanesh, I've created a new issue to list all of the code changes needed for Would you like to focus just on the single |
Yes I shall take note of this and focus on a single file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[deleted]
@@ -8,7 +8,6 @@ | |||
<link type="text/css" rel="stylesheet/less" href="{% static "less/setup.less" %}"/> | |||
{% endblock extra_css %} | |||
|
|||
{% block backbone_template %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the user setup wizard still work with this block
tag removed?
@brylie Closing this issue since It has been distributed. |
Closes #1199
Description
replaces the update-settings.html and removes settings.html, mnimalistic html changes.