new: remove closed beta and invitation functionality #859 #861
Conversation
Removing functionality for closed beta.
Removing html files for beta blocker and invitations and updating decorators.
|
Hello @jithenshriyan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-15 08:05:26 UTC |
Trying to fulfill the line length requirement
|
Thanks. We will need to make a database migration for this pull request. Are you able to successfully run the command |
|
No, I've installed PostgreSQL, Redis, and a virtual environment. I'm getting an error when running
Do I need to change the versions labeled to the latest ones in order for pip to install them? Also, once I've completed that, how do I create the environment variables on Mac and finally populate the database? Thanks! |
|
Psycopg2 2.8.6 is a valid release (and installs in my virtual environment): https://www.psycopg.org/articles/2020/09/06/psycopg-286-released/ Are you installing the requirements globally or in a virtual environment? |
|
I'm installing everything locally and I believe it's on my virtual env. I have the following already setup:
I'm stuck at the requirements file and environment variables. Is it fine if I make the changes without having to set up all the databases and users? I won't be using it after, and I've tried setting up everything but it didn't work. Thanks. |
|
I was able to get docker set up on my computer and it was so much easier to set up other projects. When setting this project up on Docker, there was an error with your requirements.txt file.
If we're able to get this fixed, then the entire project will be set up on my computer and I can fix the PR. |
|
I was suspecting that Python 2 was the issue. We should now be targeting Python 3.7+. I'll create an issue to make sure we are not specifying Python 2 anywhere. Also, the main goal of the current release is to remove many dependencies, to the point where even Docker should be unnecessary unless it is desirable to use Postgres for local development. |
|
I created an issue to clean up the Dockerfile #865 |
| @@ -99,8 +99,7 @@ def cw_register(request): | |||
| user = authenticate(username=username, password=password) | |||
|
|
|||
| account = Account(user=user) | |||
| if not settings.CLOSED_BETA: | |||
| account.beta_access = True | |||
| account.beta_access = True | |||
There was a problem hiding this comment.
Let's remove this field entirely, since there will no longer be a beta_access field in the Account model.
| @@ -139,7 +139,6 @@ class Account(models.Model): | |||
| "self", related_name="followings", symmetrical=False | |||
| ) | |||
|
|
|||
| beta_access = models.BooleanField(default=False) | |||
There was a problem hiding this comment.
makemigrations command after changing model fields.
|
Got it. Has the Docker issue been fixed? If so, I can get it set up quickly on my computer and make the changes. |
|
@jithenshriyan yes, we just merged an improved Dockerfile. :-) |
|
@jithenshriyan please let me know your status with this issue. I'm available to help resolve any issues you might be facing. |
|
@jithenshriyan are you able to create the migrations now? This pull request looks great overall! |
|
@all-contributors please add @jithenshriyan for code @jithenshriyan I'm adding you as a code contributor for your efforts, even though we haven't been able to merge them yet :-) |
|
I've put up a pull request to add @jithenshriyan! 🎉 |
|
Closing, since this work has been completed. |
Remove: closed beta and invitation functionality.
Closes #849.
Changes proposed in this pull request:
Remove Beta_Blocker function and decorator from custom_decorators.py and views.py
Remove HTML files for closed beta features
Remove functions and settings for closed beta features
Sorry about the last two PRs I had opened and closed. I had chosen your base repository as master and saw there were 10,000 changes. I figured out I need to choose develop as the base repo. Let me know if there's anything else. Thanks!