fix: Only switch dir for building with preset #275
Conversation
Osse
force-pushed
the
switch-dir-only-presets
branch
from
771897a to
85aace5
Compare
|
Can you give a reproduce method? |
|
Sure. Currently on holiday, but I'll be able to in a week or so. |
Ok, enjoy your holiday 😄 |
Osse
force-pushed
the
switch-dir-only-presets
branch
3 times, most recently
from
7a1a7e6 to
7334e9c
Compare
When using presets CMake's cwd *must* be the directory where the preset files are. Fix this by only using config.cwd when building with presets.
Osse
force-pushed
the
switch-dir-only-presets
branch
from
7334e9c to
34d28e1
Compare
|
I have tested more, and I found that my change fixes something but I'm not quite sure what yet 😄 Will need to do some more testing. Please don't merge yet. Also, formatting fails but the code that fails is not mine, so I'm not sure what you prefer I do about that. |
ok, I'll wait.
You can also fix that if not too much. 😄 |
config:build_directory_path() is relative to nvim's cwd, not the cwd as given in the config, so cmake --build will fail if config.cwd is a subdirectory of nvim's cwd. On the other hand, when using build presets CMake's cwd must be the directory where the preset files are. Fix this by only using config.cwd when building with presets.