Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EAGLE-3698]-split-handle batch #236

Merged
merged 10 commits into from
Dec 4, 2023
Merged

[EAGLE-3698]-split-handle batch #236

merged 10 commits into from
Dec 4, 2023

Conversation

phatvo9
Copy link
Contributor

@phatvo9 phatvo9 commented Nov 30, 2023

What

Split part of #227, handle batch

@phatvo9 phatvo9 mentioned this pull request Nov 30, 2023
Closed
ackizilkale
ackizilkale approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@ackizilkale ackizilkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tough PR by nature, since we have to update all these examples to handle batching. With examples comes the difficulty to maintain obviously :(

But looking good to me. Please wait for Harmit's comments also.

HarmitMinhas96
HarmitMinhas96 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@HarmitMinhas96 HarmitMinhas96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mostly minor comments.

Additionally, out of scope for this ticket, but maybe we should build some CI around this to run the defined test against some generated dummy models for each model type.

clarifai/models/model_serving/examples/visual_embedding/README.md Show resolved Hide resolved
clarifai/models/model_serving/pb_model_repository.py Outdated Show resolved Hide resolved
clarifai/models/model_serving/models/inference.py Outdated Show resolved Hide resolved
clarifai/models/model_serving/models/inference.py Outdated Show resolved Hide resolved
clarifai/models/model_serving/pb_model_repository.py Outdated Show resolved Hide resolved
clarifai/models/model_serving/models/model_types.py Outdated Show resolved Hide resolved
clarifai/models/model_serving/cli/deploy_cli.py Outdated Show resolved Hide resolved
@phatvo9 phatvo9 merged commit e1bb21a into master Dec 4, 2023
6 checks passed
@phatvo9 phatvo9 deleted the EAGLE-3698_handle-batch branch December 4, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackizilkale ackizilkale ackizilkale approved these changes

@HarmitMinhas96 HarmitMinhas96 HarmitMinhas96 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phatvo9 @ackizilkale @HarmitMinhas96