[EAGLE-3792]-Test case for model upload #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| steps: | ||
| - name: Install dependencies | ||
| run: | |
There was a problem hiding this comment.
the indentation is broken here, you either need to indent lines 17-20 to match 16 or remove 2 spaces from 16 to match 17-20 and then also fix line 22 and below
There was a problem hiding this comment.
Thanks for spotting that error
| - name: start triton | ||
| run: | | ||
| tritonserver --model-repository ./tests/dummy_triton_models --exit-on-error false & | ||
| background: true |
There was a problem hiding this comment.
this doesnt seem to actually do anything
|
This is necessarily a huge PR. Went through it, did not find anything wrong. @phatvo9 how long do you think these tests will take to run? |
With these dummy models, I think the test won't take more than 15 seconds |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test dummy models for triton code