Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX-896]: Update Model Predict CLI #500

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

srikanthbachala20
Copy link
Contributor

Why

  • To support multi-input models predictions
  • get_input usage is removed from Model Predict CLI as unable to provide the app_id (given app_id is of model)
  • Added get_input method to support Model Predict CLI in future

How

  • Removed the exception part to guarantee single type of input
  • Removed get_input usage in Model Predict CLI
  • Added get_input method to Inputs class

Tests

  • Added in tests/test_data_upload.py

* [WFP-902]: Fixed Deployment Tests

* [WFP-902]: Fixed Deployment Tests
Copy link

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 67%
clarifai.client 71%
clarifai.client.auth 74%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 9%
clarifai.runners.models 56%
clarifai.runners.utils 65%
clarifai.schema 100%
clarifai.urls 80%
clarifai.utils 77%
clarifai.utils.evaluation 67%
clarifai.workflows 94%
Summary 68% (4408 / 6527)

Minimum allowed line rate is 50%

Copy link
Contributor

@luv-bansal luv-bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Predict CLI is still broken due to the two types of user_id used in the predict methods. Specifically, if cc, np, or dpl is used with the predict CLI for predictions with a dedicated model, it will not work.

@sanjaychelliah @srikanthbachala20 I'm not sure if we want to address this in this PR or a follow-up PR. We can merge this, but a separate ticket should be created to fix above issue.

@sanjaychelliah
Copy link
Contributor

The Predict CLI is still broken due to the two types of user_id used in the predict methods. Specifically, if cc, np, or dpl is used with the predict CLI for predictions with a dedicated model, it will not work.

@sanjaychelliah @srikanthbachala20 I'm not sure if we want to address this in this PR or a follow-up PR. We can merge this, but a separate ticket should be created to fix above issue.

Hey @luv-bansal . We'll do that in a separate PR. Thanks for reminding!

@srikanthbachala20 srikanthbachala20 merged commit 196be86 into master Feb 5, 2025
17 checks passed
@srikanthbachala20 srikanthbachala20 deleted the DEVX-896-Update-Model-Predict-CLI branch February 5, 2025 09:08
@luv-bansal luv-bansal mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants