Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGLang Llama 3.2 11b Multimodal Model #119

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

luv-bansal
Copy link
Contributor

No description provided.

@luv-bansal luv-bansal changed the title SGLang Llama 3.2 11b SGLang Llama 3.2 11b Multimodal Model Feb 3, 2025

model:
id: "llama3_2-11b-vision-instruct"
user_id: "meta"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to leave user_id as user_id and app_id as app_id

Copy link
Contributor

@ackizilkale ackizilkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my tiny ask, fix and merge.

@ackizilkale ackizilkale self-requested a review February 4, 2025 18:17
temperature=temperature,
max_tokens=max_tokens,
top_p=top_p,
extra_body={"stop_token_ids": [151645, 151643]},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is mysterious to me. If I change the model, do I need to change these? You may want to leave a comment here.

# if checkpoints section is in config.yaml file then checkpoints will be downloaded at this path during model upload time.
# checkpoints = os.path.join(os.path.dirname(__file__), "checkpoints")

checkpoints = "unsloth/Llama-3.2-11B-Vision-Instruct"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we want to do this really high up in the code as a variable so it serves better as an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants