forked from Clarity-Innovation-Lab/executor-dao
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vote delegation #4
Open
radicleart
wants to merge
9
commits into
main
Choose a base branch
from
feat/vote-delegation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: test fix for the update to dev fund to include start height per developer tidy up before merging pull request NFT Escrow tests 1. Cont test for dev fund 2. Refactored some boilerplate methods (setup) into a common utils class 3. Begun nft escrow 1. Added test for dev fund 2. Refactored some boilerplate methods (setup) into a common utils class Moved test proposal clarity contracts to the test folder Moved test proposal clarity contracts to the test folder Unit tests for governance token, executive proposals and emergency executive extensions Unit tests for governance token, executive proposals and emergency executive extensions Proposal voting tests Unit tests for executor dao NB this branch will likely undergo a lot of refactoring.
* main: Chore: changed is/set whitelisted to is/set allowed
* main: Change is/set allowed to is/set allowlisted Chore: changed is/set whitelisted to is/set allowed # Conflicts: # Clarinet.toml # README.md # contracts/external/nft-escrow.clar # contracts/proposals/edp003-allowlist-escrow-nft.clar # contracts/proposals/edp003-manage-escrow-nft.clar # contracts/proposals/edp003-whitelist-escrow-nft.clar # tests/nft-escrow_test.ts # tests/proposals/edp008-1-allowlist-nft-escrow.clar # tests/src/nft-escrow-client.ts # tests/src/utils.ts
* main: Change is/set allowed to is/set allowlisted Chore: changed is/set whitelisted to is/set allowed # Conflicts: # Clarinet.toml # README.md # contracts/external/nft-escrow.clar # contracts/proposals/edp003-allowlist-escrow-nft.clar # contracts/proposals/edp003-manage-escrow-nft.clar # contracts/proposals/edp003-whitelist-escrow-nft.clar # tests/nft-escrow_test.ts # tests/proposals/edp008-1-allowlist-nft-escrow.clar # tests/src/nft-escrow-client.ts # tests/src/utils.ts
This was raised originally by Marvin in the reference executor DAO and is now applicable here for the EcosystemDAO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.