Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken look in admin notice #205

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

bahiirwa
Copy link
Collaborator

All Submissions:

Removing the woocommerce-message class fixes this. It has a restricted width.

Closes #203 .

How to test the changes in this Pull Request:

  1. Install CC
  2. Check the admin notice requiring Compat plugin install

Screenshot - before:

Screenshot 2020-01-26 at 18 43 26

Screenshot - after:

Screenshot 2020-01-26 at 18 43 42

@bahiirwa bahiirwa requested review from timbocode and a user January 26, 2020 16:03
@codecov-io
Copy link

Codecov Report

Merging #205 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #205      +/-   ##
=============================================
+ Coverage      40.82%   40.82%   +<.01%     
  Complexity     13445    13445              
=============================================
  Files            367      367              
  Lines          51271    51271              
=============================================
+ Hits           20932    20933       +1     
+ Misses         30339    30338       -1
Impacted Files Coverage Δ Complexity Δ
includes/class-wc-tax.php 79.67% <0%> (+0.27%) 130% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a8ccb...316f078. Read the comment docs.

Copy link
Contributor

@timbocode timbocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks better

@timbocode timbocode merged commit 12a44ca into ClassicPress:develop Jan 26, 2020
@bahiirwa bahiirwa deleted the fix-css-notices branch February 7, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Width flaws in admin notices
3 participants