QAOA MaxCut #845
QAOA MaxCut #845
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
NadavClassiq
force-pushed
the
qaoa_branch
branch
from
db6e5c2 to
d02bb0b
Compare
NadavClassiq
force-pushed
the
qaoa_branch
branch
from
d02bb0b to
bee6ae1
Compare
| @@ -0,0 +1,786 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,786 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,786 @@ | |||
| { | |||
There was a problem hiding this comment.
1 - Why the mixing operation is Digital? and the Phase Analog?
2 - "toward a partition that maximizes the number of cut edges.":
*towards
*maybe minimizes the hamiltonian? instead of the cut. and put the f_obj in negative sign
Reply via ReviewNB
| @@ -0,0 +1,786 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #1. from classiq import *
I would put either all necessary imports in a single cell, or import each package in the first place where it is needed
Reply via ReviewNB
| @@ -0,0 +1,786 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #14. plt.title("Graph Visualization for Max-Cut")
This is not visualization of the Max-Cut, just the graph
Reply via ReviewNB
| @@ -0,0 +1,786 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #4. num_layers: CInt,
maybe you don't need this - use the gammas\betas size instead
Reply via ReviewNB
| @@ -0,0 +1,786 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #6. params: CArray[CReal, NUM_LAYERS * 2],
Maybe worth an explanation - this is an execution parameter, to be set by the sample method later on in the classical optimization loop
Reply via ReviewNB
| @@ -0,0 +1,786 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #9. allocate(v.size, v)
no need to provide v.size, because it was declared in the main signature
Reply via ReviewNB
| @@ -0,0 +1,786 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,786 @@ | |||
| { | |||
There was a problem hiding this comment.
PR Description
Some notes
Please make sure that you placed the files in an appropriate folder
And that the files have indicative names.
Please note that Classiq runs automatic code linting, which may minorly alter some files.
pre-commit, you may runpre-commit install, and then at each commit, your files will be altered in a similar way