Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry even if there is an error #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

retry even if there is an error #188

wants to merge 1 commit into from

Conversation

nikhilpandit
Copy link

No description provided.

@nikhilpandit nikhilpandit requested review from cozmo and peternga August 7, 2018 22:15
@mohit
Copy link
Contributor

mohit commented Aug 7, 2018

we should carefully watch error rates and latencies in today's test, since this might have some implications there.

@cozmo
Copy link
Contributor

cozmo commented Aug 7, 2018

Looks like we didn't run make generate or whatever here. The sample code hasn't been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternga peternga peternga approved these changes

@cozmo cozmo cozmo approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhilpandit @mohit @cozmo @peternga