feat(cc-logs-addon-runtime): init component #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdesoyres-cc
requested review from
hsablonniere,
Galimede,
florian-sanders-cc,
roberttran-cc,
HeleneAmouzou and
clara-layus-cc
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/addon-logs/index.html. This preview will be deleted once this PR is closed. |
florian-sanders-cc
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Great job @pdesoyres-cc I've played a little bit with the component and checked the code, couldn't find much to say, only 2 nitpicks 👍
I think it shows the logs UI framework you've built is reaching maturity, well done 🙌
roberttran-cc
approved these changes
Mar 21, 2025
src/components/cc-logs-addon-runtime/cc-logs-addon-runtime.smart.js
Outdated
Show resolved
Hide resolved
pdesoyres-cc
force-pushed
the
addon-logs
branch
from
47c0bc0 to
822cd9f
Compare
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do?
This PR adds
cc-logs-addon-runtimecomponent that displays addon logsHow to review