Skip to content

Commit

Permalink
GeoMakie ext: no shading by default
Browse files Browse the repository at this point in the history
GeoMakie extension `heatmap2D_on_globe!()`
did not specify the default shading, therefore it had shading (Makie
default), which made plots where obscured in some regions, making it
difficult to clearly visualize colors. This commit fixes this issue by changing the default
shading to noshading.
  • Loading branch information
AlexisRenchon authored and ph-kev committed Oct 18, 2024
1 parent 009fc51 commit a536423
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ pfull_var = ClimaAnalysis.get(simdir, short_name = "pfull", reduction = "2.0d",
- `Var.shift_to_start_of_previous_month` now checks for duplicate dates and throws an error
if duplicate dates are detected.
- Fix issue with plotting multiple figures at the same time.
- Improve shading for `Visualize.heatmap2D_on_globe!`.

v0.5.10
-------
Expand Down
5 changes: 4 additions & 1 deletion ext/ClimaAnalysisGeoMakieExt.jl
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,17 @@ function Visualize.heatmap2D_on_globe!(
:mask => Dict(),
),
)
default_kwargs = Dict(:plot => Dict(:shading => Makie.NoShading))
default_and_more_kwargs =
ClimaAnalysis.Utils._recursive_merge(default_kwargs, more_kwargs)
return _geomakie_plot_on_globe!(
place,
var;
p_loc,
plot_coastline,
plot_colorbar,
mask,
more_kwargs,
more_kwargs = default_and_more_kwargs,
plot_fn = Makie.surface!,
)
end
Expand Down

0 comments on commit a536423

Please sign in to comment.