Skip to content

Commit

Permalink
Merge pull request #2805 from CliMA/ck/refactor_surface
Browse files Browse the repository at this point in the history 
Simplify surface function
  • Loading branch information
@charleskawczynski
charleskawczynski authored Mar 19, 2024
2 parents 3145a5e + 741eca2 commit 64d60d7
Showing 1 changed file with 61 additions and 63 deletions.
124 changes: 61 additions & 63 deletions src/surface_conditions/surface_conditions.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ function update_surface_conditions!(Y, p, t)
Fields.field_values(Fields.level(Fields.local_geometry_field(Y.c), 1))
(; ᶜts, ᶜu, sfc_conditions) = p.precomputed
(; params, sfc_setup, atmos) = p
thermo_params = CAP.thermodynamics_params(params)
surface_params = CAP.surface_fluxes_params(params)
int_ts_values = Fields.field_values(Fields.level(ᶜts, 1))
int_u_values = Fields.field_values(Fields.level(ᶜu, 1))
int_z_values =
Expand All @@ -38,7 +40,8 @@ function update_surface_conditions!(Y, p, t)
projected_vector_data(CT1, int_u_values, int_local_geometry_values),
projected_vector_data(CT2, int_u_values, int_local_geometry_values),
int_z_values,
params,
thermo_params,
surface_params,
atmos,
sfc_temp_var...,
)
Expand Down Expand Up @@ -125,6 +128,9 @@ function set_surface_conditions!(p, surface_conditions, surface_ts)
)
end

ifelsenothing(x, default) = x
ifelsenothing(x::Nothing, default) = default

"""
surface_state_to_conditions(
surface_state,
Expand All @@ -133,7 +139,8 @@ end
interior_u,
interior_v,
interior_z,
params,
thermo_params,
surface_params,
atmos,
sfc_prognostic_temp, (default = nothing)
)
Expand All @@ -148,62 +155,36 @@ function surface_state_to_conditions(
interior_u,
interior_v,
interior_z,
params,
thermo_params,
surface_params,
atmos,
sfc_prognostic_temp = nothing,
)
(; parameterization, T, p, q_vap, u, v, gustiness, beta) = surface_state
(; parameterization, p, q_vap) = surface_state
(; coordinates) = surface_local_geometry
FT = eltype(params)
thermo_params = CAP.thermodynamics_params(params)
surface_params = CAP.surface_fluxes_params(params)
FT = eltype(thermo_params)

(!isnothing(q_vap) && atmos.moisture_model isa DryModel) &&
error("surface q_vap cannot be specified when using a DryModel")
if isnothing(sfc_prognostic_temp)
if isnothing(T) && (

T = if isnothing(sfc_prognostic_temp)
if isnothing(surface_state.T) && (
coordinates isa Geometry.LatLongZPoint ||
coordinates isa Geometry.LatLongPoint
)
if atmos.sfc_temperature isa ZonallyAsymmetricSST
#Assume a surface temperature that varies with both longitude and latitude, Neale and Hoskins, 2021
T =
(
(-60 < coordinates.lat < 60) ?
(
FT(27) * (
FT(1) -
sind((FT(3) * coordinates.lat) / FT(2))^2
) + FT(273.16)
) : FT(273.16)
) + (
(
-180 < coordinates.long < 180 &&
-30 < coordinates.lat < 30
) ?
(
FT(3) *
cosd(coordinates.long + FT(90)) *
cospi(FT(0.5) * coordinates.lat / FT(30))^2 + FT(0)
) : FT(0)
)
elseif atmos.sfc_temperature isa ZonallySymmetricSST
#Assume an idealized latitude-dependent surface temperature
T = FT(271) + FT(29) * exp(-coordinates.lat^2 / (2 * 26^2))
end
elseif isnothing(T)
surface_temperature(atmos.sfc_temperature, coordinates)
elseif isnothing(surface_state.T)
# Assume that the latitude is 0.
T = FT(300)
FT(300)
else
surface_state.T
end
else
T = sfc_prognostic_temp
end
if isnothing(u)
u = FT(0)
end
if isnothing(v)
v = FT(0)
sfc_prognostic_temp
end
u = ifelsenothing(surface_state.u, FT(0))
v = ifelsenothing(surface_state.v, FT(0))

if isnothing(p)
# Assume an adiabatic profile with constant cv and R above the surface.
cv = TD.cv_m(thermo_params, interior_ts)
Expand Down Expand Up @@ -250,12 +231,8 @@ function surface_state_to_conditions(
)

if parameterization isa ExchangeCoefficients
if isnothing(gustiness)
gustiness = FT(1)
end
if isnothing(beta)
beta = FT(1)
end
gustiness = ifelsenothing(surface_state.gustiness, FT(1))
beta = ifelsenothing(surface_state.beta, FT(1))
inputs = SF.Coefficients(
interior_values,
surface_values,
Expand All @@ -266,12 +243,8 @@ function surface_state_to_conditions(
)
elseif parameterization isa MoninObukhov
if isnothing(parameterization.fluxes)
if isnothing(gustiness)
gustiness = FT(1)
end
if isnothing(beta)
beta = FT(1)
end
gustiness = ifelsenothing(surface_state.gustiness, FT(1))
beta = ifelsenothing(surface_state.beta, FT(1))
isnothing(parameterization.ustar) || error(
"ustar cannot be specified when surface fluxes are prescribed",
)
Expand Down Expand Up @@ -305,7 +278,7 @@ function surface_state_to_conditions(
shf = θ_flux * ρ * TD.cp_m(thermo_params, ts)
lhf = q_flux * ρ * TD.latent_heat_vapor(thermo_params, ts)
end
if isnothing(gustiness)
if isnothing(surface_state.gustiness)
buoyancy_flux = SF.compute_buoyancy_flux(
surface_params,
shf,
Expand All @@ -318,8 +291,10 @@ function surface_state_to_conditions(
# TODO: We are assuming that the average mixed layer depth is
# always 1000 meters. This needs to be adjusted for deep
# convective cases like TRMM.
else
gustiness = surface_state.gustiness
end
isnothing(beta) || error(
isnothing(surface_state.beta) || error(
"beta cannot be specified when surface fluxes are prescribed",
)
if isnothing(parameterization.ustar)
Expand Down Expand Up @@ -352,17 +327,42 @@ function surface_state_to_conditions(
ts,
surface_local_geometry,
atmos,
params,
thermo_params,
)
end

function surface_temperature(::ZonallySymmetricSST, coordinates)
FT = eltype(coordinates.lat)
T = FT(271) + FT(29) * exp(-coordinates.lat^2 / (2 * 26^2))
return T
end

function surface_temperature(::ZonallyAsymmetricSST, coordinates)
(; lat, long) = coordinates
FT = eltype(coordinates.lat)
#Assume a surface temperature that varies with both longitude and latitude, Neale and Hoskins, 2021
T =
(
(-60 < lat < 60) ?
(FT(27) * (FT(1) - sind((FT(3) * lat) / FT(2))^2) + FT(273.16)) :
FT(273.16)
) + (
(-180 < long < 180 && -30 < lat < 30) ?
(
FT(3) * cosd(long + FT(90)) * cospi(FT(0.5) * lat / FT(30))^2 +
FT(0)
) : FT(0)
)
return T
end

"""
atmos_surface_conditions(
surface_conditions,
ts,
surface_local_geometry,
atmos,
params,
thermo_params,
)
Adds local geometry information to the `SurfaceFluxes.SurfaceFluxConditions` struct
Expand All @@ -374,13 +374,11 @@ function atmos_surface_conditions(
ts,
surface_local_geometry,
atmos,
params,
thermo_params,
)
(; ustar, L_MO, buoy_flux, ρτxz, ρτyz, shf, lhf, evaporation) =
surface_conditions

thermo_params = CAP.thermodynamics_params(params)

surface_normal = C3(unit_basis_vector_data(C3, surface_local_geometry))
energy_flux = (; ρ_flux_h_tot = (shf + lhf) * surface_normal)
moisture_flux =
Expand Down

0 comments on commit 64d60d7

Please sign in to comment.