Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for conservation of kinetic energy with topography #2961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dennisYatunin
Copy link
Member

Purpose

This PR adds a test for exact conservation of kinetic energy in the presence of topography. The test currently passes with the changes from #2960, and it would be helpful to see whether it passes without those changes.

To-do

Update the relevant Jacobian terms, and add a test that uses implicit timestepping.


  • I have read and checked the items on the review checklist.

@szy21
Copy link
Member

szy21 commented Apr 26, 2024

Do you need to change something in the Jacobian as well?

@dennisYatunin
Copy link
Member Author

Yes, I need to turn off gravity and pressure gradients in the vertical velocity tendency derivatives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants