-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use deep atmosphere equations by default #3422
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have one shallow atmosphere example in ci (you can choose anything, e.g. baroclinic wave).
modified: config/default_configs/default_config.yml
37599a4
to
f34a307
Compare
I think we may want to write a few more unit tests in ClimaCore to show that this is working for our finite difference stencils. In particular, I think it may be helpful to show that our FD operators are conservative. Thoughts? |
What unit tests do we have now that is only for shallow atmosphere? |
I don't know that we have conservation tests in a deep atmosphere |
We should add them if we don't have them. Could you point me to the tests for shallow atmosphere in ClimaCore? |
That's a good question, I don't actually see any at first glance. I only some conservation tests for horizontal limiters. We should probably add some, I think we can spin off a test from one of the column heat/wave examples without too much work. |
I'm a bit concerned about the two orders of magnitude increase in conservation error in |
Also this one |
Draft PR simplifies result tracking for tests with deep-atmos equations as part of the default configuration.
Target config: 70km depth, 99 vertical centers (100 face levels).