Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYAMOND Summer low-resolution simulation #3458

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Nov 26, 2024

Purpose

Add DYAMOND Summer low-resolution simulation.

To-do

Content


  • I have read and checked the items on the review checklist.

@sriharshakandala sriharshakandala marked this pull request as draft November 26, 2024 18:51
@sriharshakandala sriharshakandala changed the title Initial conditions from file (rough draft, work-in-progress) Initial conditions from file Nov 26, 2024
@sriharshakandala sriharshakandala force-pushed the sk/dyamond_summer_ics branch 2 times, most recently from 65e9bea to 9471246 Compare November 26, 2024 19:44
src/solver/type_getters.jl Outdated Show resolved Hide resolved
Copy link
Member

@akshaysridhar akshaysridhar Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to drop support for this older artifact getter file/functions (any such retrieval function will now be defined within the AtmosArtifacts utility module, making use of the clima_artifact macro ; so the DYAMOND_SUMMER_ICS_p98dev_dataset_path() function is not necessary.

@@ -7,6 +7,7 @@ function trigger_download(lazy_download = true)
@info "topo dataset path:`$(topo_res_path())`"
@info "MiMA convective gravity wave path:`$(mima_gwf_path())`"
@info "GFDL OGWD test data:`$(gfdl_ogw_data_path())`"
@info "DYAMOND summer initial conditions path:`$(DYAMOND_SUMMER_ICS_p98deg_dataset_path())`"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the artifact_funcs.jl file - everything moving forward is expected to rely on the AtmosArtifacts utility module; so this change is not required.

- use "Earth" topography
- reduce dt to 1 sec and add some diagnostics for debugging purposes
@sriharshakandala sriharshakandala changed the title Initial conditions from file DYAMOND Summer low-resolution simulation Nov 27, 2024
@sriharshakandala sriharshakandala changed the title DYAMOND Summer low-resolution simulation DYAMOND Summer low-resolution simulation Nov 27, 2024
Comment on lines +767 to +772
Y.f.u₃ .=
ᶠinterp.(
ClimaCore.Geometry.Covariant3Vector.(
ClimaCore.Geometry.WVector.(vel)
)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that it helps with stability if u₃ is not prescribed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be consistent with @akshaysridhar 's earlier observations !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s because the initial w is too large for our timestep. We can consider adding a threshold too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants