-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYAMOND Summer
low-resolution simulation
#3458
base: main
Are you sure you want to change the base?
Conversation
65e9bea
to
9471246
Compare
9471246
to
f63259b
Compare
artifacts/artifact_funcs.jl
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to drop support for this older artifact getter file/functions (any such retrieval function will now be defined within the AtmosArtifacts
utility module, making use of the clima_artifact
macro ; so the DYAMOND_SUMMER_ICS_p98dev_dataset_path()
function is not necessary.
@@ -7,6 +7,7 @@ function trigger_download(lazy_download = true) | |||
@info "topo dataset path:`$(topo_res_path())`" | |||
@info "MiMA convective gravity wave path:`$(mima_gwf_path())`" | |||
@info "GFDL OGWD test data:`$(gfdl_ogw_data_path())`" | |||
@info "DYAMOND summer initial conditions path:`$(DYAMOND_SUMMER_ICS_p98deg_dataset_path())`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the artifact_funcs.jl
file - everything moving forward is expected to rely on the AtmosArtifacts
utility module; so this change is not required.
- use "Earth" topography - reduce dt to 1 sec and add some diagnostics for debugging purposes
DYAMOND Summer
low-resolution simulation
Y.f.u₃ .= | ||
ᶠinterp.( | ||
ClimaCore.Geometry.Covariant3Vector.( | ||
ClimaCore.Geometry.WVector.(vel) | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that it helps with stability if u₃ is not prescribed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be consistent with @akshaysridhar 's earlier observations !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it’s because the initial w is too large for our timestep. We can consider adding a threshold too.
Purpose
Add
DYAMOND Summer
low-resolution simulation.To-do
Content