Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve threading in _set_interpolated_values_device #2159

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Improve threading in _set_interpolated_values_device #2159

merged 1 commit into from
Jan 27, 2025

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Jan 24, 2025 •
edited by Sbozzolo
Loading

This is a more parallelized alternative to #2156. cc @Sbozzolo

Closes #2156

@charleskawczynski charleskawczynski mentioned this pull request Jan 24, 2025
Closed
@charleskawczynski
Copy link
Member Author

charleskawczynski commented Jan 24, 2025 •
edited
Loading

It's surprising to me that this is erroring in _apply_mpi_bitmask!, I think there are just bugs in interpolate logic. Maybe related to #2108?

Actually, I mixed up the order of (i, j, k) = CartesianIndices(map(x -> Base.OneTo(x), inds))[I].I and 1 ≤ I ≤ prod(inds) || return nothing, which is important. That should be fixed.

@charleskawczynski charleskawczynski force-pushed the ck/dist_remap_threading branch 3 times, most recently from 82afd8c to 8c1c3f6 Compare January 24, 2025 20:08
@charleskawczynski
Remove duplicate env spec
ea21873 
Improve threading in _set_interpolated_values_device

Try debugging

Fixes + use length(out)

Test dist remapping only

Fixes

Add pipeline back in
@charleskawczynski charleskawczynski merged commit d887e86 into main Jan 27, 2025
12 of 14 checks passed
@charleskawczynski charleskawczynski deleted the ck/dist_remap_threading branch January 27, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
performance refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @Sbozzolo