Remove minimum and close Issue #975
#1042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmdeck
commented
Feb 21, 2025
…iMA/ClimaLand.jl into kd/performance_investigations
kmdeck
commented
Feb 21, 2025
| @@ -85,10 +85,9 @@ function update_albedo!(bc::AtmosDrivenFluxBC, p, soil_domain, model_parameters) | |||
| ) | |||
| @. S_sfc = ∫H_S_e_dz / ∫H_dz | |||
| else | |||
| @. p.soil.sub_sfc_scratch = effective_saturation(ν, p.soil.θ_l, θ_r) | |||
There was a problem hiding this comment.
this removes an allocation too, but I dont think this branch is being used with our current config
kmdeck
changed the title
minimum and close Issue #982minimum and close Issue #975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Removes allocation of parameter combo struct Issue #975
Closes PR #982
Removes "minimum" computation by computing this once and storing it
To-do
update benchmark times
Content