Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug with iwc name #1043

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix bug with iwc name #1043

merged 1 commit into from
Feb 21, 2025

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Feb 21, 2025

Purpose

Our diagnostics name "iwc_1m" fails in plotting because it is thought to be "iwc" at 1minute. This changes the name by removing "_1m".

To-do

Content

  • I have read and checked the items on the review checklist.

@kmdeck kmdeck requested a review from Sbozzolo February 21, 2025 18:01
Sbozzolo
Sbozzolo approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also call it iwc1m is you want to preserve the information

@kmdeck kmdeck enabled auto-merge (squash) February 21, 2025 18:10
@kmdeck kmdeck merged commit c8fb12c into main Feb 21, 2025
16 checks passed
@kmdeck kmdeck deleted the kd/diagnostic_name_change branch February 21, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmdeck @Sbozzolo