some comments

examples/freely_decaying_mediterranean.jl

@@ -64,7 +64,7 @@ heatmap!(ax, interior(model.tracers.T, :, :, Nz), colorrange = (10, 20), colorma
 ax  = Axis(fig[1, 2])
 heatmap!(ax, interior(model.tracers.S, :, :, Nz), colorrange = (35, 40), colormap = :haline)
 
-simulation = Simulation(model, Δt = 20, stop_iteration = 100)
+simulation = Simulation(model, Δt = 20, stop_iteration = 100, stop_time = 10*365days)
 
 function progress(sim) 
     u, v, w = sim.model.velocities  
@@ -83,7 +83,7 @@ simulation.callbacks[:progress] = Callback(progress, IterationInterval(10))
 # warm up for 100 iterations!
 run!(simulation)
 
-simulation.stop_time = 10*365days
+simulation.stop_iteration = Inf
 
 wizard = TimeStepWizard(; cfl = 0.2, max_Δt = 10minutes, max_change = 1.1)
 

src/Bathymetry.jl

@@ -187,7 +187,8 @@ function interpolate_bathymetry_in_passes(native_h, target_grid; passes = 10)
         new_size = (Nλ[pass], Nφ[pass], 1)
 
         @debug "pass number $pass with size $new_size"
-        new_grid = LatitudeLongitudeGrid(size = new_size, 
+        new_grid = LatitudeLongitudeGrid(architecture(target_grid),
+                                         size = new_size, 
                                      latitude = (latitude[1],  latitude[2]), 
                                     longitude = (longitude[1], longitude[2]), 
                                             z = (0, 1),

src/DataWrangling/ECCO2.jl

@@ -243,6 +243,19 @@ function adjusted_ecco_field(variable_name;
     return f
 end
 
+"""
+    initialize!(model;
+                overwrite_existing = false,
+                filename = "./data/adjusted_ecco_tracers.nc", 
+                kwargs...)
+
+Initialize `model`. The keyword arguments `kwargs...` take the form `name=data`,
+where `name` refers to one of the fields of `model.velocities` or `model.tracers`, 
+and the `data` may be
+ (1) an array
+ (2) a function with arguments `(x, y, z)` for 3D fields, `(x, y)` for 2D fields and `(x)` for 1D fields
+ (3) a symbol corresponding to a fldname of `ecco2_tracer_fields`
+"""
 function initialize!(model;
                      overwrite_existing = false,
                      filename = "./data/adjusted_ecco_tracers.nc",