Cleaner syntax for ECCOFieldTimeSeries and ECCORestoring #284
+87
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's still kind of confusing how |
Agree 👍🏼 |
|
Ok, I will clean up |
glwagner
changed the title
|
Still TODO here is to clean up the constructor for |
simone-silvestri
approved these changes
Dec 3, 2024
navidcy
reviewed
Dec 3, 2024
navidcy
reviewed
Dec 3, 2024
| @@ -248,7 +249,7 @@ Build a forcing term that restores to values stored in an ECCO field time series | |||
| The restoring is applied as a forcing on the right hand side of the evolution equations calculated as | |||
|
|
|||
| ```math | |||
| Fψ = μ r (ψ_ECCO - ψ) | |||
| Fψ = r μ (ψ_ECCO - ψ) | |||
There was a problem hiding this comment.
Suggested change
| Fψ = r μ (ψ_ECCO - ψ) | |
| Fψ = r μ (ψ_{ECCO} - ψ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231