-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate sea ice in the flux computation #294
Open
simone-silvestri
wants to merge
108
commits into
main
Choose a base branch
from
ss/integrate-sea-ice
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ss/one-degree-take3
Co-authored-by: Gregory L. Wagner <[email protected]>
The sea ice model is not quite ready in this PR, but the fluxes have changed to allow the integration of a sea ice model. I would probably merge this and integrate the sea ice in another PR. As an example for the integration we can use the one degree simulation. |
idealized_atmosphere.mp4 |
@simone-silvestri can you hold commits on this branch for a bit? I'm working on it. Just got a bunch of conflicts. |
…Ocean.jl into ss/integrate-sea-ice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a tentative implementation for atmosphere-sea-ice computations to be able to integrate sea-ice in the
OceanSeaIceModel
.The objective is trying to reuse as much as possible of the infrastructure in place for atmosphere - ocean fluxes
I think everything is roughly in place, we just need to change the surface properties and implement a way to limit the surface temperature to the melting temperature in the surface temperature computation