Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate sea ice in the flux computation #294

Open
wants to merge 108 commits into
base: main
Choose a base branch
from

Conversation

simone-silvestri
Copy link
Collaborator

@simone-silvestri simone-silvestri commented Dec 11, 2024

This PR is a tentative implementation for atmosphere-sea-ice computations to be able to integrate sea-ice in the OceanSeaIceModel.

The objective is trying to reuse as much as possible of the infrastructure in place for atmosphere - ocean fluxes

I think everything is roughly in place, we just need to change the surface properties and implement a way to limit the surface temperature to the melting temperature in the surface temperature computation

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 298 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (a193aee) to head (3483964).

Files with missing lines Patch % Lines
...els/CrossRealmFluxes/cross_realm_surface_fluxes.jl 0.00% 86 Missing ⚠️
...ssRealmFluxes/compute_atmosphere_surface_fluxes.jl 0.00% 85 Missing ⚠️
...SeaIceModels/CrossRealmFluxes/state_differences.jl 0.00% 28 Missing ⚠️
...dels/CrossRealmFluxes/atmosphere_sea_ice_fluxes.jl 0.00% 18 Missing ⚠️
...almFluxes/constant_coefficient_turbulent_fluxes.jl 0.00% 15 Missing ⚠️
src/OceanSeaIceModels/ocean_sea_ice_model.jl 0.00% 14 Missing ⚠️
src/SeaIceSimulations/SeaIceSimulations.jl 0.00% 13 Missing ⚠️
src/OceanSeaIceModels/OceanSeaIceModels.jl 0.00% 10 Missing ⚠️
...sRealmFluxes/similarity_theory_turbulent_fluxes.jl 0.00% 8 Missing ⚠️
...Models/CrossRealmFluxes/atmosphere_ocean_fluxes.jl 0.00% 7 Missing ⚠️
... and 6 more
Additional details and impacted files
@@          Coverage Diff           @@
##            main    #294    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         34      38     +4     
  Lines       1951    2087   +136     
======================================
- Misses      1951    2087   +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simone-silvestri
Copy link
Collaborator Author

The sea ice model is not quite ready in this PR, but the fluxes have changed to allow the integration of a sea ice model. I would probably merge this and integrate the sea ice in another PR.

As an example for the integration we can use the one degree simulation.

@simone-silvestri simone-silvestri marked this pull request as ready for review December 16, 2024 07:00
@glwagner
Copy link
Member

idealized_atmosphere.mp4

@glwagner
Copy link
Member

glwagner commented Jan 6, 2025

@simone-silvestri can you hold commits on this branch for a bit? I'm working on it. Just got a bunch of conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants