Corrected ECCOMetaData code bit in tutorial to dates

[the-ethan-hunt]

In reference to Issues #224 and #227, the tutorial in readme.md contains

set!(ocean.model, T = ClimaOcean.ECCOMetadata(:temperature; date),
                  S = ClimaOcean.ECCOMetadata(:salinity; date))`

This results in the error:

MethodError: no method matching ClimaOcean.DataWrangling.ECCO.ECCOMetadata(::Symbol; date::DateTimeProlepticGregorian)

Signatures of the function indicate:

methods(ClimaOcean.ECCOMetadata)
[1] ClimaOcean.DataWrangling.ECCO.ECCOMetadata(name::Symbol; dates, version, dir)
[2] ClimaOcean.DataWrangling.ECCO.ECCOMetadata(name::Symbol, date; ...)
[3] ClimaOcean.DataWrangling.ECCO.ECCOMetadata(name::Symbol, date, version; dir)
[4] ClimaOcean.DataWrangling.ECCO.ECCOMetadata(name::Symbol, dates::D, version::V, dir::String) where {D, V}

The following version seems to work:

set!(ocean.model, 
    T = ClimaOcean.ECCOMetadata(:temperature; dates=[date]), 
    S = ClimaOcean.ECCOMetadata(:salinity; dates=[date]))

I continue to face errors regarding ECCO data post 1995 but that's a 401 login node error 😄

[glwagner]

Suggested change

	set!(ocean.model, T = ClimaOcean.ECCOMetadata(:temperature, dates= date),
	S = ClimaOcean.ECCOMetadata(:salinity, dates= date))
	set!(ocean.model, T = ClimaOcean.ECCOMetadata(:temperature, dates = date),
	S = ClimaOcean.ECCOMetadata(:salinity, dates = date))

[glwagner]

We want ClimaOcean.ECCOMetadata(:temperature; dates=date) not ClimaOcean.ECCOMetadata(:temperature; dates=[date]).

I do think the syntax is a little confusing so cc'ing @simone-silvestri here.

[simone-silvestri]

We could add an additional date keyword argument?

[glwagner]

We could add an additional date keyword argument?

Or we can rethink the design where dates as a vector means "many dates" but a single date represents one instance. For example, many dates could be represented as a vector of ECCOMetadata.