A low resolution coupled simulation #345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ss/one-degree-take3
…into ss/one-degree-take3
…into ss/one-degree-take3
…nto ss/new-coupled-sim
|
maybe also delete the unused experiments |
glwagner
approved these changes
Feb 20, 2025
Yes please |
glwagner
reviewed
Feb 22, 2025
| @inbounds begin | ||
| Tm = melting_temperature(liquidus, S[i, j, k]) | ||
| T[i, j, k] = max(T[i, j, k], Tm) | ||
| end |
There was a problem hiding this comment.
also this should go in source code for sure and write a test
glwagner
reviewed
Feb 22, 2025
| if k == size(grid, 3) | ||
| T[i, j, k] = melting_temperature(liquidus, S[i, j, k]) | ||
| end | ||
| @inbounds T[i, j, Nz] = melting_temperature(liquidus, S[i, j, Nz]) | ||
| end | ||
|
|
||
| function adjust_ocean_temperature!(ocean, sea_ice) |
There was a problem hiding this comment.
Suggested change
| function adjust_ocean_temperature!(ocean, sea_ice) | |
| function above_freezing_ocean_temperature!(ocean, sea_ice) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be a playground to test the fluxes in a simple setting.