Clean up checks for convergence and limiters #361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR cleans up the code we use to check convergence and limiters in our CI, and it enforces strict tests for algorithm convergence.
There are two significant issues that are not addressed in this PR:
Overall, I think our ERK, ARK, and Rosenbrock algorithms are functioning correctly in the absence of limiters. Hopefully the tests I've added will catch convergence issues in the future, such as the one that was introduced in v0.7.39.
Content
compute_convergence.jl
andsummarize_convergence.jl
plotting_utils.jl
, since it is no longer necessarysummarize_convergence
benchmark_step
so that it can handle missing implicit/explicit tendenciessummarize_convergence
so that it can plot the results for algorithms that failed to converge