Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solves bug when calling ConjugateGradientPoissonSolver without specifying preconditioner #3846

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Solves bug when calling ConjugateGradientPoissonSolver without specifying preconditioner #3846

merged 3 commits into from
Oct 22, 2024

Conversation

tomchor
Copy link
Collaborator

@tomchor tomchor commented Oct 10, 2024 •
edited
Loading

See #3831 (comment)

Solves #3829

@glwagner
Copy link
Member

I can fix this if you want

@tomchor
Copy link
Collaborator Author

tomchor commented Oct 11, 2024

I can fix this if you want

Thanks, yeah feel free to jump in!

@ali-ramadhan
Copy link
Member

This might be a duplicate of PR #3830 but looks like both will be superseded by PR #3847 which is doing the refactoring necessary for this fix.

ali-ramadhan
ali-ramadhan approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@ali-ramadhan ali-ramadhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomchor!

PS: You can mark this PR as resolving #3829

@tomchor
Copy link
Collaborator Author

tomchor commented Oct 22, 2024

Thanks @tomchor!

I mean, the real hero was @simone-silvestri with #3847 :)

PS: You can mark this PR as resolving #3829

Just did!

@tomchor tomchor merged commit fe49923 into main Oct 22, 2024
46 checks passed
@tomchor tomchor mentioned this pull request Oct 22, 2024
Closed
@tomchor tomchor deleted the tc/conjugate-solver-bug branch November 1, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ali-ramadhan ali-ramadhan ali-ramadhan approved these changes

@glwagner glwagner Awaiting requested review from glwagner

@simone-silvestri simone-silvestri Awaiting requested review from simone-silvestri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomchor @glwagner @ali-ramadhan