Reduce parameter space for velocity tendency kernels #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is nice, but can you implement this uniformally for all models? It'll be faster to do it now, rather than run into this issue in the future and be scratching our heads because we forgot about this |
simone-silvestri
changed the title
u and v hydrostatic tendency kernels
|
I suspect that this PR is slowing down the code. I ll investigate |
simone-silvestri
added
the
🚨 DO NOT MERGE 🚨
simone-silvestri
removed
the
🚨 DO NOT MERGE 🚨
glwagner
approved these changes
Nov 19, 2024
glwagner
reviewed
Nov 19, 2024
| model.clock) | ||
|
|
||
| u_kernel_args = tuple(start_momentum_kernel_args..., u_immersed_bc, end_momentum_kernel_args...) | ||
| v_kernel_args = tuple(start_momentum_kernel_args..., v_immersed_bc, end_momentum_kernel_args...) | ||
|
|
||
| launch!(arch, grid, kernel_parameters, | ||
| compute_hydrostatic_free_surface_Gu!, model.timestepper.Gⁿ.u, grid, | ||
| active_cells_map, u_kernel_args; | ||
| active_cells_map, u_kernel_args, model.forcing.u; |
There was a problem hiding this comment.
Suggested change
| active_cells_map, u_kernel_args, model.forcing.u; | |
| active_cells_map, tuple(u_kernel_args..., model.forcing.u); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use complicated forcings in the model, for example the ECCORestoring type we use in ClimaOcean, we could incur in parameter space by passing all the forcings in the kernels, see:
https://buildkite.com/clima/climaocean-examples/builds/942#01932566-3781-41ab-9464-031b0bfcf562
and
CliMA/ClimaOcean.jl#244
This PR should reduce the parameter space in those cases by passing only the u and v specific forcings.