Polar boundary conditions #3965
Open
+158
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
PolarBoundaryConditions. This was originally done in #3953 withviewsof abstract operations (allowing reductions on windowed fields).However, two problems arose:
BoundaryConditionsmodule is loaded before theFieldsmodule, requiring quite a mess for a boundary condition which is, in the end, quite simple.For this reason, I would like to close #3953 and just implement a simple
PolarBoundaryConditionin this PR with a dedicated kernel to compute the mean of the first / last row.I can open an issue regarding
viewsofAbstractOperationsso we can tackle it in a new fresh PR.