Fix flux_dn_dir not updated in all sky two stream #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We only need |
Adjusting that can be done in a separate PR |
Prior to this commit, `flux_dn_dir` was not set in the two stream case for non-gray radiation, leading to garbage values (whatever was in the memory at init). Now, the variable is accumulated over for ever g-point.
|
Updated to only update the first level (this means that the rest of the array will be undefined) |
sriharshakandala
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
flux_dn_dirwas not set in the two stream case for non-gray radiation, leading to incorrect values (whatever was in the memory at init). Now, the variable is accumulated over for ever g-point.