small fix for aerosol size bin #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -282,6 +282,7 @@ function locate_merra_size_bin(size_bin_limits, aerosize) | |||
| bin = ibin | |||
| break | |||
| end | |||
| bin = nbins | |||
There was a problem hiding this comment.
This looks fine if your intent is to extrapolate. A conservative approach is to check if the particle size falls within the bin extrema limits, throw an error if it doesn't (which is best done upstream, e.g. ClimaAtmos.jl).
sriharshakandala
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Right now, the aerosols are assigned bin 1 when the size is larger than the largest size bin. I think it is safer to assign them to the last size bin.
To-do
Content