Adds requested changes.

ClickHouse · Feb 10, 2025 · 6378cf8 · 6378cf8
1 parent 6a77f93
commit 6378cf8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 17 deletions.
diff --git a/src/components/Grid/Cell.tsx b/src/components/Grid/Cell.tsx
@@ -59,8 +59,8 @@ export const Cell = memo(
     const cellRef = useRef<HTMLDivElement>(null);
 
     useEffect(() => {
-      if (!rowAutoHeight) return;
-      else if (cellRef.current) {
+      if (!rowAutoHeight) {return;}
+      if (cellRef.current) {
         const height = cellRef.current.getBoundingClientRect().height;
         updateRowHeight(rowIndex, height);
       }

diff --git a/src/components/Grid/Grid.test.tsx b/src/components/Grid/Grid.test.tsx
@@ -71,8 +71,8 @@ describe("Grid", () => {
   };
 
   const renderGrid = ({
-    rowCount,
-    columnCount,
+    rowCount = 20,
+    columnCount = 20,
     columnWidth,
     onColumnResize,
     focus,
@@ -82,8 +82,8 @@ describe("Grid", () => {
   }: Props) =>
     renderCUI(
       <Grid
-        rowCount={rowCount ?? 20}
-        columnCount={columnCount ?? 20}
+        rowCount={rowCount}
+        columnCount={columnCount}
         columnWidth={columnWidth ?? columnWidthTestFn}
         cell={Cell}
         focus={focus ?? { row: 0, column: 0 }}
@@ -129,11 +129,7 @@ describe("Grid", () => {
     const cell = queryByTestId("row-cell-0-0");
     expect(cell).toBeDefined();
 
-    if (!cell) {
-      throw new Error("Cell with data-testid 'row-cell-0-0' not found");
-    }
-
-    const computedHeight = window.getComputedStyle(cell).height;
+    const computedHeight = window.getComputedStyle(cell!).height;
     const heightValue = parseFloat(computedHeight);
     expect(heightValue).toBe(33);
   });
@@ -148,11 +144,7 @@ describe("Grid", () => {
     const cell = queryByTestId("row-cell-0-0");
     expect(cell).toBeDefined();
 
-    if (!cell) {
-      throw new Error("Cell with data-testid 'row-cell-0-0' not found");
-    }
-
-    const computedHeight = window.getComputedStyle(cell).height;
+    const computedHeight = window.getComputedStyle(cell!).height;
     expect(computedHeight).toBe("100%");
   });
 });
diff --git a/src/components/Grid/Grid.tsx b/src/components/Grid/Grid.tsx
@@ -227,7 +227,7 @@ export const Grid = forwardRef<HTMLDivElement, GridProps>(
 
     const updateRowHeight = useCallback(
       (rowIndex: number, height: number) => {
-        if (!rowAutoHeight) return;
+        if (!rowAutoHeight) {return;}
         const prevHeight = rowHeightsRef.current.get(rowIndex) ?? 0;
         if (height > prevHeight) {
           rowHeightsRef.current.set(rowIndex, height);