Adding a solid version of badges #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
crisalbu
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Thanks for working on this, Gareth! ❤️
After doing the squint test and having tested the contrast on https://coolors.co/contrast-checker/, I realised some of these didn't have the best contrast. It was good, but not great, so I changed some of the colors for dark mode. Plus, that green was too flashy compared to the more toned down version we had on red, blue, etc.
Would you mind updating them, please?
|
The colours have been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In addition to our regular, more opaque badges, the docs team has a need for more visible variants. This PR adds the new set of badge colours under the
typeprop.Note: Breaking change to tokens. @gjones will author an accompanying Control Plane PR to ensure no references to the discontinued
badge.color.xtokens remain.CleanShot.2025-01-13.at.13.08.42.mp4