Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title font weights & adjust dots-vertical-double icon #538

Closed
wants to merge 2 commits into from

Conversation

natalyjazzviolin
Copy link
Contributor

Helps with https://github.com/ClickHouse/control-plane/issues/12818

Why

Currently we cannot define a font weight for the title component. The dots-vertical-double icon is slightly different from the design.

What

This adds a font weight prop to the title component; having this prop will allow us to align closer with the initial design.
Screenshot 2025-02-07 at 12 18 08 PM

This alters the dots-vertical-double icon slightly to better align with the current design:
Screenshot 2025-02-07 at 12 14 11 PM

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:20pm

@gjones
Copy link
Collaborator

gjones commented Feb 7, 2025

Hey @natalyjazzviolin, I'm not sure we want to allow a content prop on the titles as it'll lead to inconsistencies. Is there a reason this is coming up?

@gjones
Copy link
Collaborator

gjones commented Feb 7, 2025

So to add a little more context on this @natalyjazzviolin. The options for titles are exactly the same in Figma as they are in the code, they're driven from the design tokens. If a designer is using a custom font size or weight then that's more of a design problem than a development problem. They'll need to justify their decision and figure out whether its something we want to add to the library, but I'd rather not open the door to those levels of inconsistency right now if that's ok. Perhaps the visual discrepancy you're seeing is down to the various rendering differences between figma and browsers?

On the icon, the icon used in the Click UI library is the same as in Figma, so, again this could be rendering, but I'd prefer if we didn't alter the image in the component library independent of the Figma version.

@natalyjazzviolin
Copy link
Contributor Author

@gjones understood, thank you for the explanation! Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants