-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support chDB as a driver #369
base: main
Are you sure you want to change the base?
Conversation
feat: first working implementation of chdb as driver
also tagging @auxten if you have insight on the chDB part |
It looks great. I'm here for any issue or question :) |
chdb-dev: | ||
type: clickhouse | ||
driver: chdb | ||
chdb_state_dir: "chdb_state" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in dbt target
provided folder
examples/taxis/profiles.yml
Outdated
type: clickhouse | ||
driver: chdb | ||
chdb_state_dir: "chdb_state" | ||
chdb_dump_dir: "dump" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe more granular and able to load single file or glob expression
@ThomAub There are some lint issues to fix, and we also need unit and integration tests. You can "Allow edits from maintainers." |
Hi folks, Thank you for your contribution! Before reviewing your PR, please add the following:
Looking forward to reviewing this! |
…tories fix: Get all .sql files in all subdirectories
Added unit test for chDB dbt materialization Updated changelog with a description of the new feature
feat: Add tests and update changelog
@ThomAub In the chdb v2.2.0b0, the chdb.dbapi is totally refactored. The API and behavior suppose to be not changed.
|
I am eagerly waiting for this so that I can use chDB instead of duckdb for doing local transformations (WIP). Our warehouse is clickhouse, so it would make a lot of sense for us to have a compatible SQL for the local processing as well. @ThomAub Thanks for the great work. When do you think it would be generally available and maybe with some helpful doc or blog post? |
We are actively testing this in house so we will soon make it a proper PR with documentation before end of year |
@ThomAub Can you please update us on the PR state ? Is there any more work required to get this merged ? |
Hello @arun11299 We are facing some issues with using CHDB for testing purposes. We have a Clickhouse cluster, and CHDB is not working well for distributed or replicated tables. |
@ThomAub Can you describe in detail the problem you have? And which version of chDB you are using, for the scenario of dbt I really recommend chDB v3.0.0 |
@ThomAub Maybe a dumb question, but why ChDb needs to worry about replicated merge tables ? Isn't it just embedded and hence single node? Anyways, in my use case, I want to use ChDb for doing data pipeline implementation and testing in dev environment which is replaced by clickhouse cloud in production. |
Summary
This is a first proposition for #297. It's currently working for our use case of embedded ClickHouse for unit tests with DBT.
It would be great to have some feedback in the direction of this feature implementation !
We would also be interested in how should we add Unit and integration tests or even a tutorial ?
Checklist
Delete items not relevant to your PR: