feat/add freshdesk properties #3576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Added Freshdesk Variables
* instantiate freshdesk client * create ticket with freshdesk client * add frehdesk client * add freshdesk to fixtures * refactor tests for Freshdesk * remove redundant type hint * change decorators to context managers * fix mock setup * add type hints * fix freshdesk ticket submission * rename FreshDesk client variable * rename ticket client variable * update ticket handling integration * refactor integration with ticket handler * refactor models for attachments and responses * refactor for Freshdesk integration * refactor attachment hanlding for Freshdesk * reformat * inject Freshdesk client dependency * use OrdersAPI instance * initialize ticket handler and OrdersAPI * reformat * rename Freshdesk client variable * add error handling and logging * refactor error handling * remove commentsx * remove api variable * remove logging at the info level * replace osticket with freshdesk * update ticket mock creation * use https protocol * remove _url method * remove comments * correct a typo * use file attachment method from utils * move out attachment processing * add attachment handling * check attributes values * return single attachment * fix temp attachment method * remove attachment model --------- Co-authored-by: AhmedAmin-ki <[email protected]> Co-authored-by: Vincent Janvid <[email protected]>
seallard
reviewed
Aug 20, 2024
|
Moved multipart handling to |
|
An error occurred while trying to automatically change base from
dev-freshdesk
to
master
September 3, 2024 12:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added