Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly override template storage implementations for remote #1582

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Jan 26, 2025

Motivation

When api-impl splitting the RemoteTemplateStorage impl was not done correctly. Methods that handle file streams (in & out) were just called as usual RPCs which is not possible.

Modification

This PR overrides the specific method implementations and uses the chunked file transfer api to transfer filestreams.

Result

The template storage is working properly from the wrapper side.

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: driver An issue/pull request releated to the driver module code t: fix A pull request introducing a fix for a bug. in: wrapper An issue/pull request releated to the wrapper module code labels Jan 26, 2025
@0utplay 0utplay requested a review from derklaro January 26, 2025 11:46
@0utplay 0utplay self-assigned this Jan 26, 2025
@0utplay 0utplay requested a review from derklaro January 29, 2025 20:20
Copy link

github-actions bot commented Jan 29, 2025

Test Results

 48 files  ±0   48 suites  ±0   1m 43s ⏱️ +23s
432 tests ±0  432 ✅ ±0  0 💤 ±0  0 ❌ ±0 
763 runs  ±0  763 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1e82dc9. ± Comparison against base commit 8bfd442.

This pull request removes 32 and adds 32 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-01-20
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 20:10:55.743577231
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 20:10:55.743701984Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 20:10:55.743724506Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 20:10:55.743748811+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 20:10:55.743770802-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-01-20T20:10:55.743898220
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-01-20T20:10:55.744055543Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-01-20T20:10:55.740133077Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [5] 2025-01-20T20:02:35.740136594Z
…
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-01-29
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 20:34:41.042966656
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 20:34:41.043119568Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 20:34:41.043142040Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 20:34:41.043166445+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 20:34:41.043187634-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-01-29T20:34:41.043312124
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-01-29T20:34:41.043470777Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-01-29T20:34:41.035392394Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [5] 2025-01-29T20:26:21.035396782Z
…

♻️ This comment has been updated with latest results.

@0utplay 0utplay merged commit 6445995 into nightly Feb 7, 2025
5 checks passed
@0utplay 0utplay deleted the fix/remote-template-storage-streaming branch February 7, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: driver An issue/pull request releated to the driver module code in: wrapper An issue/pull request releated to the wrapper module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants