CP-20221: Labels and Annotations #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrice32
reviewed
Dec 23, 2024
teevans
approved these changes
Dec 23, 2024
Great question! I think in most "production" environments we've seen they already have a deployment. I think for easy of install we had this enabled, but maybe we should disable it? @dmepham would like your input here. |
beckilee
reviewed
Dec 23, 2024
| - [`cert-manager` Documentation](https://cert-manager.io/docs/) | ||
| - [CloudZero Agent Helm Chart README](./README.md) | ||
| - [ValidatingWebhookConfiguration Reference](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/#validatingwebhookconfiguration-v1-admissionregistration-k8s-io) | ||
| - [Helm Troubleshooting Guide](https://helm.sh/docs/chart_best_practices/troubleshooting/) |
There was a problem hiding this comment.
This URL is broken; should we link to https://helm.sh/docs/faq/troubleshooting/ instead?
Co-authored-by: Becki Lee <[email protected]>
Co-authored-by: Becki Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
N/A