Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tpl helm function on kubeStateMetrics url #96

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mysiki
Copy link

@mysiki mysiki commented Nov 8, 2024

By submitting a PR to this repository, you agree to the terms within the CloudZero Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Add tpl helm function for kubeStateMetrics url to allow use to provide helm variable instead of static value

Testing

No tested, can be done by helm values file like

cloudAccountId: "XYZ"
clusterName: "test"
region: "XYZ"
validator:
  serviceEndpoints:
    kubeStateMetrics: "{{ $.Values.clusterName }}.externalMetrics.svc.cluster.local:8080"

Checklist

  • I have added documentation for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@mysiki mysiki requested a review from a team as a code owner November 8, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant