Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesize OCI tenancy names as tags #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

intjonathan
Copy link
Collaborator

@intjonathan intjonathan commented May 12, 2023

Description

Add the tenancy name of each resource to the CBF output files. It's added as a synthesized tag on the resource, at least for now, as CBF doesn't yield a standard account name field. An additional API call is required for each unique tenancy ID in the OCI cost file set, along with permissions necessary in Oracle for the API user to make the call (TENANCY_INSPECT).

References

Fulfills #2

Testing

  • Verify that a new drop populates the tenant name on all rows.
  • Verify that CZ backfills this tag to old lineitems.

Checklist

  • I have added documentation for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@intjonathan intjonathan requested a review from a team as a code owner May 12, 2023 00:12
@intjonathan intjonathan force-pushed the tenancy-name-fetch branch from 9e795c1 to bd0d6aa Compare May 12, 2023 23:40
muellerk22
muellerk22 previously approved these changes May 15, 2023
@intjonathan
Copy link
Collaborator Author

This is working currently in our fetcher lambda! We have a permissions issue to sort out in our OCI org that I'd like to bring docs in here about before this lands.

@silvexis
Copy link
Member

Is this still valid? Sorry for the delay.

@intjonathan
Copy link
Collaborator Author

It needs an update, will fix and ping when ready.

@intjonathan intjonathan changed the title WIP: Tenancy name fetch Tenancy name fetch Jan 29, 2024
@intjonathan intjonathan changed the title Tenancy name fetch Synthesize OCI tenancy names as tags Jan 29, 2024
@intjonathan
Copy link
Collaborator Author

@silvexis Added docs and RFR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants