-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli client [DO NOT MERGE] #65
base: master
Are you sure you want to change the base?
Conversation
rdb.table('Dealership').insert(req.body).run(conn); | ||
conn.close(); | ||
}); | ||
res.send({message: 'hello'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like leftovers? If the insert was a success the endpoint should return a success message or json object that has "success" or "failure" etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed -- this is just there until I can figure out what the bug is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, it will return HTTP 201 (Created).
@@ -0,0 +1,16 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file @pcgeek86 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmmm, good question. I presume this is coming from Visual Studio Code. Here's an article that talks about it:
https://code.visualstudio.com/docs/languages/javascript
I can remove it from the repo, although it might make sense to leave it. We could both benefit from it, if we use VSCode, although it obviously isn't a requirement. Looks like it mainly provides Intellisense hints to VSCode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove it, since its really not source code the particular the the app, but the specific developer.
…ook like connection close before query was finished
@pcgeek86 should work now.
Logs from front end container
|
Conflicts: frontend/package.json
Add tox and setup.py files
@pcgeek86 you can merge in master to this branch, master is updated against new FH instance and slaves use new cli now. So should build correctly without FH/cli specific issues |
I will be working on this to update the APIs, then merge in. Once done, I will merge the APIs back into #75 so we can write more tests and merge those in. |
dealership.js
dbutils.js
to its own, shared directory, and updated references@wallnerryan could you help me figure out what's causing this error when POST'ing to
/dealerships
?This is the PowerShell call that I'm using, sending a simple JSON payload in the HTTP body.