podman: add info log when returning OCF_NOT_RUNNING #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are multiple cases where OCF_NOT_RUNNING is returned and unfortunately, there are rare cases where the container is, in fact, running. We add an info log so we have something to look at in case the heartbeat fails for seemingly no reason.
|
Can one of the admins verify this patch? |
|
that was the error I was looking for fyi |
|
Could we add a retry here instead ? If it's a race condition that we sometimes hit, re-trying should pass the second time and avoid a costly fencing event. |
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents-pipeline/job/PR-1829/1/input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are multiple cases where OCF_NOT_RUNNING is returned and unfortunately, there are rare cases where the container is, in fact, running.
We add an info log so we have something to look at in case the heartbeat fails for seemingly no reason.