Add ability for host to change game name #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add game lobby name change command
|
Nightly build for this pull request:
|
|
yeah, the CnCNet lobby is different from a game (game room) |
Add example to chatbox command list
SadPencil
changed the title
SadPencil
requested changes
Feb 12, 2025
|
please double check the lobby stuffs in the git diff. I saw this word again in the XML comment. |
SadPencil
requested changes
Feb 14, 2025
SadPencil
approved these changes
Feb 14, 2025
pzhlkj6612
suggested changes
Feb 14, 2025
| /// what is wrong with the name.</returns> | ||
| public static string IsGameNameValid(string gameName) | ||
| { | ||
|
|
| @@ -239,17 +240,14 @@ private void BtnLoadMPGame_LeftClick(object sender, EventArgs e) | |||
|
|
|||
| private void BtnCreateGame_LeftClick(object sender, EventArgs e) | |||
| { | |||
| string gameName = tbGameName.Text.Replace(";", string.Empty); | |||
|
|
|||
|
I just tested this locally, there is a problem: As player 1 (Host)
As player 2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for the host to change a game's lobby name from within the lobby itself. The host can type:
/gamename <newname>The new name is validated, then broadcast to all online players, and all players in the channel.
I've moved the lobby name validation checks to the NameValidator.cs file.