Cod 674 collect profiles while benchmarks are running #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
3 tasks
This comment was marked as outdated.
This comment was marked as outdated.
GuillaumeLagrange
requested changes
Mar 26, 2025
crates/codspeed/src/fifo.rs
Outdated
| use std::os::unix::fs::OpenOptionsExt; | ||
| use std::path::PathBuf; | ||
|
|
||
| pub const RUNNER_CTL_FIFO: &str = "/tmp/runner.ctl.fifo"; |
There was a problem hiding this comment.
We could replace the /tmp previx with an env variable which would be set by the runner ?
There was a problem hiding this comment.
Just thought about this again: I don't think it actually makes that much sense to do this. When having multiple runner instances, we would need to overwrite the env variable. So I think it makes this a bit more complicated for no added benefit
Is there any benefit to this that I'm missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: