Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed api compatibility issues: #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

misterbobdobalina
Copy link

Fixed api compatibility issues:

android:minSdkVersion="8"
android:targetSdkVersion="19"

However,
TargetApi wasn't introduced until api level 16,
which won't work with api level 8 as above.

Same with:
Build.VERSION_CODES.HONEYCOMB added in api level 11
View.LAYER_TYPE_SOFTWARE added in api level 11
Replaced them with their constant values instead.

I have verified that it works on api level 14. It won't compile
otherwise.

Finally:
readRanges() never uses its input parameters in:
private void readRanges(final Resources res, final int rangesId, final int colorsId)

    if (rangesId > 0 && colorsId > 0) {
        final String[] ranges = res.getStringArray(R.array.ranges);
        final String[] colors = res.getStringArray(R.array.rangeColors)
        ...

Changed it so that it uses rangesId and colorsId instead.

I have tried this as an apklib an it workds. It was incorrect as
it was before, because it wouldn't reference the correct resources
if I remember correctly.

android:minSdkVersion="8"
android:targetSdkVersion="19"

However,
TargetApi wasn't introduced until api level 16,
which won't work with api level 8 as above.

Same with:
Build.VERSION_CODES.HONEYCOMB added in api level 11
View.LAYER_TYPE_SOFTWARE added in api level 11
Replaced them with their constant values instead.

I have verified that it works on api level 14. It won't compile
otherwise.

Finally:
readRanges() never uses its input parameters in:
    private void readRanges(final Resources res, final int rangesId, final int colorsId)

        if (rangesId > 0 && colorsId > 0) {
            final String[] ranges = res.getStringArray(R.array.ranges);
            final String[] colors = res.getStringArray(R.array.rangeColors)
            ...

 Changed it so that it uses rangesId and colorsId instead.

 I have tried this as an apklib an it workds. It was incorrect as
 it was before, because it wouldn't reference the correct resources
 if I remember correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant