Add PHP 8.3 and Laravel 11 compatibility #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BernhardK91
commented
Apr 8, 2024
| @@ -4,7 +4,6 @@ includes: | |||
| parameters: | |||
| level: 4 | |||
| ignoreErrors: | |||
| - '#Access to an undefined property DOMNamedNodeMap::\$length#' | |||
There was a problem hiding this comment.
PHPStan reported that this error did not occur anymore, so I have removed the ignored error.
BernhardK91
changed the title
|
Hope this gets merged soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How to test
composer installvendor/bin/phpstanvendor/bin/phpunitDoes this need an update to the documentation?
I am not sure abot that.
Fixes #302, #304