Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed casing, changed import helpers to false in tsconfig.json so imports can be handled as we see fit #4

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Changed casing, changed import helpers to false in tsconfig.json so imports can be handled as we see fit #4

wants to merge 9 commits into from

Conversation

soundparticle
Copy link

I changed tsconfig.json to have import helpers set to false so we can organize those how we talked.

@soundparticle soundparticle requested a review from rbeatie January 14, 2019 20:43
rbeatie
rbeatie requested changes Jan 20, 2019
View reviewed changes
Copy link
Contributor

@rbeatie rbeatie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the signInForm component. Just a few patches and it will be golden. GJ

src/components/login/login.component.tsx Show resolved Hide resolved
src/components/signinForm/SigninForm.js Show resolved Hide resolved
soundparticle
soundparticle commented Jan 20, 2019
View reviewed changes
Copy link
Author

@soundparticle soundparticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a look now. I made the changes and commits all within GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbeatie rbeatie rbeatie requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soundparticle @rbeatie