Fix after filter with null #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daanvdk
force-pushed
the
fix-after-filter-with-null
branch
7 times, most recently
from
6b29daf to
504c88c
Compare
daanvdk
force-pushed
the
fix-after-filter-with-null
branch
from
504c88c to
c582ede
Compare
stefanmajoor
approved these changes
Nov 15, 2024
| self.assertEqual(self.get('zoo.name', after='a'), 'fed') | ||
|
|
||
| def test_ordered_with_null(self): | ||
| if os.environ.get('BINDER_TEST_MYSQL', '0') != '0': |
There was a problem hiding this comment.
Can you add a comment why this logic is here? That would make it clear for the next person that the test is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.