update to swift.review

[jdwagner17]

update to challenge 2

allows for any integer to be determined as prime or not prime

This also allows var isPrime to be set to either true or false from initialization.

[CLAassistant]

All committers have signed the CLA.

[jdwagner17]

@LinKCoding I believe this is now ready

[LinKCoding]

Thanks @jdwagner17 I left some messages, the biggest thing I'd want some feedback on is line 18 (and how it affects lines 25-28.

Otherwise, lgtm!

[LinKCoding]

Hey @jdwagner17, curious why this was changed, from true to false.

If we keep it as true, then we could avoid adding the else statement and block in line 25.

[jdwagner17]

I think it may be "best practice" to do it the way you suggested.

I included this because it may help new programmers better understand the relationship. If the variable is something we don't control (for whatever reason), they will know how to compensate for an unknown. That may not exist in Swift, as I noticed I could not do

var isPrime = Bool

The situation I am imagining may not exist.

[LinKCoding]

Ahhh, gotcha. So you'd want var isPrime: Bool. Which would type the variable, but not assign a value yet. This would work!

However, right now for line 25, with the else statement, you're reassign isPrime during each iteration of the loop. You don't need to do this, rather, you can make that reassignment happen outside the scope of the loop (currently on line 30 where the comment is)

[jdwagner17]

var isPrime: Bool makes sense to me, but I get an error when used in CodeAcademy.

Review.swift:64:43: error: variable 'isPrime' used before being initialized
print("Is (checkPrime) a prime number? (isPrime)!")
^
Review.swift:44:5: note: variable defined here
var isPrime: Bool
^

I think I understand your comment about iterations within the loop. Will fix in commit

[LinKCoding]

Yep, I think this is something happening under the hood, where Swift's interpreter sees a situation where isPrime might not get assigned at all before the print statement.

Try fixing the assignment issue of isPrime being assigned during each iteration and that might resolve this issue as well :)

[jdwagner17]

Hope you had a nice Easter!

There is an issue that I don't understand. I think it is why you see a simpler way to do this, and I don't. I'm going to show you new code I made and the output from CodeAcademy.

[LinKCoding]

Hope you also had a nice Easter :)

You can also share code with me via Codecademy's workspaces. Here's a sample that I made to show you what's "wrong" with your code. https://www.codecademy.com/workspaces/6435a2a522be61c54cbe68de

Something that's really helpful for me is using print() statements to check out values.

So something things I noticed:

1. isPrime is now initialized as true
2. Your if condition is that checkPrime > 2 then you go through the loop (and reassignment, etc..).

Do you see what's wrong? You can uncomment lines 10 and 16 to help you out :) (I think you might have to fork my workspace to alter the code)

[jdwagner17]

Ugh! Yes it's obvious what is wrong. Once I read...

"Your if condition is that checkPrime > 2 then you go through the loop (and reassignment, etc..)."

...I knew what I had done.

[LinKCoding]

And these things happen!

I'd still say trying to debug on your own (with print statements) is helpful and useful later down the line too.
And also, be kind to yourself!

[LinKCoding]

Good catch!

[LinKCoding]

Small nit, but please capitalize "all" => "All" -- it's a styling convention thing. Thanks :)

[jdwagner17]

so start with capital letters, unless it is the name of something (variable "isPrime").

[LinKCoding]

Yep, if it's a sentence, then we'd start with a capitalized letter for the first word.
But if it's a variable (like isPrime) or something that's always lower cased like iPad we'd opt to keep the proper spelling.