Skip to content

Elements outside of viewport are not captured. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpgo13 opened this issue Aug 8, 2017 · 3 comments
Closed

Elements outside of viewport are not captured. #24

mpgo13 opened this issue Aug 8, 2017 · 3 comments

Comments

@mpgo13
Copy link

mpgo13 commented Aug 8, 2017

Elements that are initially outside of the users viewport are not captured, which is fine, although when scrolling to the element, so the element becomes visible in the current viewport, they are still not captured:

Steps to reproduce:

  1. Create element which is initially outside of the viewport
  2. Scroll to element and make it visible
  3. Capture screenshot for comparison

Expected result: Expected Image should contain visible element
Actual result: Expected Image is empty or has wrong content.

@mpgo13
Copy link
Author

mpgo13 commented Aug 8, 2017

This happens primarily on Firefox as reported in issue DigitalProducts#47

@buresmi7
Copy link
Collaborator

buresmi7 commented Aug 9, 2017

I would like to merge w/o-jQuery branch in the near future. Could you please try this without jQuery?

@mpgo13
Copy link
Author

mpgo13 commented Aug 16, 2017

This seemed to be fixed with the w/o-jQuery branch :)

@mpgo13 mpgo13 closed this as completed Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants